Using Python3 To Estimate BIS Gear Sets For Ninja.

Added a drop-down menu for selecting Ninjutsu and Black Magic spells to test. This list currently includes elemental Black Magic I-VI, -ja, and Ninjutsu nukes. The black magic spells use the BG Wiki table for [M,V] in various dINT ranges (see get_dint_m_v.py) while the ninjutsu nukes use the [M,V] values for various dINT ranges determined from my previous testing. The BG Wiki page for ninjutsu has still not been updated to reflect my ninjutsu testing results, though.

Under the drop-down menu for spells, I've added checkboxes for bursting and futae. Futae only works for Ninjutsu nukes.

Added a "Quick-look Magic" button to test magic damage with the displayed set. While Magic Accuracy and Magic Accuracy Skill have always been tracked, I do not use them in the code yet.

I've added a "Magic Evasion" stat to the Enemy Input section, but it does not do anything right now. I need to first figure out exactly how magic accuracy affects resist rates.

Added a button to select all gear in ALL slots that your main job can equip. Keep in mind that nuking items are included now, so finding weapon skill sets will take a long time if you do not de-select the items that wouldn't affect weapon skill damage. I think I've located the main bottleneck for runtime. If I successfully fix it, then the total runtime could be reduced by as much as ~40%. I've already fixed the issue and updated the files on GitHub. The code is about 40~50% faster now. I'll post about it later.

Added the button "Run Magic" for finding the set that provide the highest magic damage. Since magic damage is always perfectly consistent, the "Run Magic" button will never produce a plot; it will stop running after finding and printing the best set.

I've removed the white box from the outputs tab since the GUI brings up a terminal anyway. I'd like to fill this empty space with the gearset stats later (attacks, accuracies, hit rates, STR, triple attack, etc)

I've reduced the code's runtime significantly (~50% reduction based on cProfile) when determining weapon skill sets by using the equation-form of attacks per weapon (mainhand/offhand) per weapon skill, accounting for attack order, the 8-hit limit, and MA probabilities (see get_ma_rate3() in get_ma_rate.py). I was previously running 50000 simulations (for every set tested) and taking an average to determine this.

Because runtime has improved significantly, I've added just about every item in the gear.py file to the lists by default. You can remove these items in the gear.py file, unless you're using the executable version of the code. Alternatively, you can use the checkboxes in the "Select Gear" tab to deselect items you don't wish to test. The code will only test/select items that your selected main job can use anyway. I tried to add the correct jobs (except SMN) to all gear, but I may have missed a few.

Magic Accuracy and Magic Evasion now affect spell damage. Magic hit rate is calculated as explained on BG Wiki. I'm using the contribution from dINT from Lute's 2016 blog (Japanese), which appears to give -30 to +30 magic accuracy depending on dINT. I may be misinterpreting these blog results, but I'll look into it more later. I do not include resistance ranks for now. If you keep Magic Evasion at <=0, then the code treats hit rate as 100%, otherwise the code will calculate hit rate based on the Magic Evasion you provided and then cap hit rate at 95%.

Thanks to help from Sylph.Brahmsz, we now know exactly how Smite (and Last Resort) is included in attack calculations. I've added Smite when simulating jobs (and subjobs) with a Smite trait and using a 2-handed weapon. We can now calculate all DRK sets with all buff states using the code. Naturally, low-buff Scythe likes Ratri+1 while Great Sword likes NyameR25B with Empy+3 hands.

I've added gear stats to the outputs tab to fill in some of the empty space. Clicking the "Calculate Stats" button in the "Inputs" tab will now show some basic stats for the selected gear and buffs.

Updated Outputs tab

Since there is a lot of gear to scroll through, the gear lists now only show items that your main job can equip. This was a surprisingly annoying change to make. I believe I've already fixed all of the edge cases that caused crashes relating to my poor coding practices, but let me know if you run into issues.

Warrior main and subjob includes Fencer traits which can be boosted by Fencer+ gear.

Scholar includes Helix II spells and an Ebullience check box. I assume as SCH you always have the correct weather up, but Hachirin no Obi is not selectable as an item for now.

Corsair can not cast spells, but I've included Quick Draw in the spell list for Corsair. Use the "Run Magic" and "Quicklook Magic" buttons to test Quick Draw. Additionally, my QD magic accuracy is probably incorrect. I recommend keeping enemy magic evasion at 0 if testing quick draw.

??? QD_Macc = Gear_Magic_Accuracy + Magic_Accuracy_Skill(main-hand weapon only) + AGI/2 + 60(Death Penalty) ???

I've added both Ranged and Magical weapon skills. I've also updated the main post to show NIN Blade: Ei and Aeolian Edge sets based on what I found using my code.

The spell list now only shows spells that your main job can use. For example: DRK only shows spells up to tier3 and COR only shows Quick Draw.

The list of weapon skills is now very large (see spoiler below). Thus I've added a filter to the weapon skill list so that it only shows weapon skills that are usable by your selected weapons (main and ranged). There is no job restriction yet.

For example: The code starts as NIN with a katana mainhand, so the default list is katana weapon skills only. If you wanted to test Empyreal Arrow, then you need to equip a bow. If you wanted to test Randgrith, then you'll need to equip a club (and optionally change you main job to WHM to get meaningful results).

Thief, including Sneak Attack and Trick Attack, has been added to the code. SA/TA are checkboxes similar to Futae, Magic Burst, and Ebullience. In order to make room for these check boxes, I setup the code to hide Futae if not NIN main, hide Ebullience if not SCH, and hide Magic Burst if not in ["NIN", "DRK", "RDM", "BLM", "WHM", "GEO", "SCH"]. I'll add DNC flourishes in a similar way.

• Both sneak attack and trick attack force 100% hit rate for the first main+sub hits of the weapon skill being used.
• The first main-hand hit will be a critical hit.
• The first main-hand hit gains bonus damage (added to its base damage) equal to 100% of the player's DEX/AGI for SA/TA. These bonuses are added before the PDIF multiplier, but after FTP is applied. Gear with "Sneak Attack +" or "Trick Attack +" increases this 100% by the bonus listed: SA+30 uses +130% DEX.
  Code

  phys = int(  ((wpn_dmg + fstr_wpn + wsc)*ftp + sneak_attack_bonus + trick_attack_bonus) * pdif

  
  

Monk, including Impetus and Footwork, has been added to the code. Impetus/Footwork were added in a similar way to SA/TA.

For Impetus I assume 90% max potency (45% crit rate, +90 attack, and +45% crit damage if using Bhikku body too).

I'm not sure how much I trust the MNK Footwork part of the code. Both Dragon Kick and Tornado Kick put out crazy damage when attack capped and with footwork between 1500-1800 TP (~80k average with ~140k peaks; see the bonus set below). Maybe this is normal, but I don't play MNK enough to know. I wasn't able to find an issue with the MNK/Footwork logic in my code, so I'm assuming this is normal. If you frequently play MNK and this doesn't sound correct, please let me know so I can figure out where I went wrong.

Empyreal Arrow now properly gains its +100% attack modifier.

The additional hits for ranged weapon skills now use WSD=0 when calculating the average damage dealt.

Nyame Helm R30B Double Attack +1 corrected to Double Attack +5

Fixed Bunzi Rod R30 Magic Attack augment +26 to +30

Bunzi Sabots R30 Magic Accuracy augment +10 to +15

Bunzi Gloves R30 Magic Burst II augment +7 to +6

Mpaca Gloves R30 was just a copy paste of R25

Ikenga Hat R25 was using R30 stats and R30 was using R25 stats

Ikenga Boots R25 was using R30 stats and R30 was using R25 stats

Sakpata Helm R30 Double Attack Damage +13 corrected to +15

All R30 Odyssey weapons have been added.

Nyame R30 Path A has been added. However, using the "Select All" buttons will not select Nyame Path A. You will have to manually click their checkboxes if you want to test Nyame Path A. This was intentional.

(I think) I saw some mention of Minstrel Mistral Axe in one of these December update threads. I've therefore added Minstrel Mistral Axe as a weapon skill option.

I've also added Raging Rush, Wheeling Thrust, Sonic Thrust, and Ground Strike. However, Nandaka's "Ignores Defense" effect is not added yet. If you want to test Nandaka, throw on a Dia1 for Nandaka sets to simulate defense-10%

R15, R20, R25, and R30 Odyssey armor are all included in the gear lists (I may add lower-ranked weapons later). You may now use the simple drop-down menu to choose which rank the "Select All" buttons will select. You can also use the "Quicklook" buttons to compare different ranking Odyssey pieces. Nyame Path A is ignored, but still included in case you wanted to select it manually.

Select Gear Tab Image

DNC has been added (with incorrect base stats). Apparently, [Climactic, Striking, Ternary] can't be used together. Those three flourishes are part of a drop-down menu so you can only select one at at time.

• Building Flourish provides +25% Attack (applied with Chaos Roll), Accuracy +40, Crit Rate +10%, and Weapon Skill damage +20% (from Job Points)
• Climactic Flourish is treated like Sneak/Trick Attack: The first main-hand hit will be a critical hit and the base damage of that hit gains a +50% CHR bonus (+70% after JP bonuses). The Empyrean +3 head increases Crit Damage by 31% for this one hit if equipped.
• Striking Flourish guarantees a double attack from your main-hand hit (by setting QA=TA=0, DA=1). The main-hand hit also gains +100% CHR bonus similar to SA/TA. Both the main-hand hit and the guaranteed double attack hit gain crit rate +70% when wearing the Empyrean +3 body.
• Ternary Flourish guarantees a triple attack from your main-hand hit (by setting QA=0, TA=1). The main-hand hit also gains +100% CHR bonus similar to SA/TA. There is nothing else fancy going on with Ternary Flourish as far as I can tell.

BST has been added (with incorrect base stats)

GEO has been added (with incorrect base stats)

RNG has been added (with incorrect base stats) without Hover Shot.

RUN has been added (with incorrect base stats)

PLD has been added (with incorrect base stats).

PUP has been added for master WS sets (with incorrect base stats). I'm interested in adding Automaton weapon skills to the "Spells" list, but this is not going to happen for many months.

I've added BLU (without any traits), but I need to read about setting BLU traits and bonus stats based on spells set.

If you've been updating the code as I've added more jobs, you've probably noticed that it's started taking a significant amount of time to use the "Select <ALL> Main Job" button, change jobs, and even just open the GUI. After adding the above jobs with their gear, the delay ended up being 3~10s, which is pretty bad, and especially annoying when testing things. I've modified how the code reads/creates equipment lists so that swapping jobs and selecting equipment is back to being nearly instant (as it should be). In general, the GUI is now much more responsive than before.

This was technically an easy fix, but there was a lot of room to mess something up relating to how the GUI interacts with itself. Let me know if you run into any weird new issues. The only "negative" thing I've seen from this change is that the gear lists can now be scrolled way beyond the displayed gear list.

I've fixed an error in Monk's base stats which gave it TA+8% (a remnant from copy/pasting THF stats to start MNK).

The "Select all" button still selects everything in the displayed list. However, the main code itself now rejects simulations where the main-hand weapon does not match the selected melee weapon skill. Similarly for ranged weapon and ranged weapon skills. Hopefully I didn't overcorrect it to reject valid sets that you'd want to check.

Ranged WSs now get their REMA/Ambuscade weapon damage bonuses.

The True Shot stat now directly increases physical ranged damage dealt. For example: True Shot +5 = +5% physical ranged damage.